[Security Solution] [Cases] Bugfix for special character tags filtering#74849
Merged
stephmilovic merged 2 commits intoelastic:masterfrom Aug 12, 2020
Merged
[Security Solution] [Cases] Bugfix for special character tags filtering#74849stephmilovic merged 2 commits intoelastic:masterfrom
stephmilovic merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
XavierM
approved these changes
Aug 12, 2020
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
This was referenced Aug 12, 2020
Merged
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
Aug 12, 2020
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
Aug 12, 2020
stephmilovic
added a commit
that referenced
this pull request
Aug 12, 2020
MindyRS
added
the
Team: SecuritySolution
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If you create a case with tags that have an AND, OR, (, ), etc... then you would blow up with an error when you try to filter based off of that like the screen shot below:
Now you don't blow up:
This fixes it by adding double quotes around the filters and a unit test to confirm the fix
Checklist
Delete any items that are not applicable to this PR.